Skip to content

Unify dpnp public API exports by refactoring dpnp_iface.py #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Unify dpnp public API exports by refactoring dpnp_iface.py #2665

wants to merge 28 commits into from
+863 −446

Conversation

@vlad-perevezentsev
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev commented Nov 13, 2025

This PR proposes to refactor the export structure of dpnp_iface.py by moving all python function exports into dpnp/__init__.py
Redundant __all__ declarations and wildcard imports inside dpnp_iface.py have been removed.

This is the first step toward unifying dpnp public API exports and eliminating wildcard imports.
A next PR will remove the remaining wildcard imports in __init__.py and finalize the unified function export

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vlad-perevezentsev
Move array creation exports from dpnp_iface.py to __init__.py
39d2ee9
@vlad-perevezentsev
Move binary operations exports from dpnp_iface.py to __init__.py
75bfb02
@vlad-perevezentsev
Move couting function exports from dpnp_iface.py to __init__.py
bcb3697
@vlad-perevezentsev
Move functional function exports from dpnp_iface.py to __init__.py
ca4e526
@vlad-perevezentsev
Move histogram function exports from dpnp_iface.py to __init__.py
804098f
@vlad-perevezentsev
Move indexing function exports from dpnp_iface.py to __init__.py
36c9173
@vlad-perevezentsev
Move linear algebra function exports from dpnp_iface.py to __init__.py
f20bdc5
@vlad-perevezentsev
Move logic function exports from dpnp_iface.py to __init__.py
bebfc84
@vlad-perevezentsev
Move manipulation function exports from dpnp_iface.py to __init__.py
defce44
@vlad-perevezentsev
Move mathematical function exports from dpnp_iface.py to __init__.py
9914214
@vlad-perevezentsev
Move nan function exports from dpnp_iface.py to __init__.py
c152d7b
@vlad-perevezentsev
Move searching function exports from dpnp_iface.py to __init__.py
6d58414
@vlad-perevezentsev
Move sorting function exports from dpnp_iface.py to __init__.py
fbb7b82
@vlad-perevezentsev
Move statistics function exports from dpnp_iface.py to __init__.py
a92158a
@vlad-perevezentsev
Move trigonometric function exports from dpnp_iface.py to __init__.py
9c96ced
@vlad-perevezentsev
Move window function exports from dpnp_iface.py to __init__.py
490c4ef
@vlad-perevezentsev
Merge master into refactor_public_api_exports
68affb3
@vlad-perevezentsev
Remove wildcard import dpnp_algo in dpnp_iface.py
47d599e
@vlad-perevezentsev
Move dpnp_iface exports to __init__.py
382f144
@vlad-perevezentsev
Merge master into refactor_public_api_exports
b5d8308
@vlad-perevezentsev
Remove unnecessary pylint disables
80ea4fb
@vlad-perevezentsev vlad-perevezentsev self-assigned this Nov 13, 2025
@vlad-perevezentsev vlad-perevezentsev added this to the 0.20.0 release milestone Nov 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

View rendered docs @ https://intelpython.github.io/dpnp/pull/2665/index.html

@coveralls
Copy link
Collaborator

coveralls commented Nov 13, 2025 •
edited
Loading

Coverage Status

coverage: 81.424% (-0.02%) from 81.447%
when pulling b210970 on refactor_public_api_exports
into 131c490 on master.

@vlad-perevezentsev vlad-perevezentsev mentioned this pull request Nov 14, 2025
Open
7 tasks
@vlad-perevezentsev vlad-perevezentsev changed the title Refactor dpnp_iface exports Unify dpnp public API exports by refactoring dpnp_iface.py Nov 14, 2025
antonwolfy
antonwolfy reviewed Nov 17, 2025
View reviewed changes
dpnp/__init__.py

__all__ = _iface__all__
__all__ += _ifaceutils__all__

Copy link
Contributor

@antonwolfy antonwolfy Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the change to the changelog

Copy link
Contributor Author

@vlad-perevezentsev vlad-perevezentsev Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog was updated in the following PR #2666 723e2c1 and contains 2 links to the PRs

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_29 ran successfully.
Passed: 1229
Failed: 0
Skipped: 7

antonwolfy
antonwolfy reviewed Nov 18, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy left review comments

@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels

None yet

Projects

None yet

Milestone

0.20.0 release

Development

Successfully merging this pull request may close these issues.

3 participants

@vlad-perevezentsev @coveralls @antonwolfy